Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported #7029

Open
pythoncarpenter opened this issue Feb 8, 2025 · 2 comments · May be fixed by netlify/build#6094
Open

npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported #7029

pythoncarpenter opened this issue Feb 8, 2025 · 2 comments · May be fixed by netlify/build#6094
Assignees
@serhalp
Labels
dependencies Pull requests that update a dependency file

Comments

@pythoncarpenter
Copy link

NPM Warns About Deprecated Pre-V9 Glob

For some time now, installing the Netlify CLI has produced this warning:

Given that Glob v9 has been out for a while, seeing this warning during installation might confuse or concern users. It's unclear whether there's a dependency chain within the Netlify CLI codebase that still relies on an older version of glob.

Steps to Reproduce

  1. Run npm install -g netlify-cli or npm install netlify-cli in a project.
  2. Observe the console output for deprecation warnings.

Expected behavior
No deprecation warnings should appear if all dependencies support and use the latest maintained version of glob.

Environment Information (Optional)

  • npm version: (e.g., 9.x)
  • Node version: (e.g., 18.x)
  • OS: (e.g., macOS 10.15.7)

Additional context

  • This warning has been persistent for quite some time, so resolving the underlying dependency would help keep the Netlify CLI installation process cleaner and more up-to-date.
serhalp added a commit to netlify/build that referenced this issue Feb 18, 2025
@serhalp
fix(deps): replace deprecated glob@8
e38f12d 
Installing netlify-cli prints a deprecation warning:
netlify/cli#7029.

I was going to upgrade `glob`, but then I remembered it's a fairly large library, so why
not use this as an opportunity to replace it? See
https://github.com/es-tooling/module-replacements/blob/main/docs/modules/glob.md.

Compare the APIs:
- https://github.com/isaacs/node-glob#readme
- https://github.com/SuperchupuDev/tinyglobby?tab=readme-ov-file#api

The only differences are option names, which I've updated.

Our uses either hardcode patterns or enforce precisely documented user patterns, so we
won't hit any of the limitations of tinyglobby.
@serhalp serhalp linked a pull request Feb 18, 2025 that will close this issue
Draft
serhalp added a commit to netlify/build that referenced this issue Feb 18, 2025
@serhalp
fix(deps): replace deprecated glob@8
677111d 
Installing netlify-cli prints a deprecation warning:
netlify/cli#7029.

I was going to upgrade `glob`, but then I remembered it's a fairly large library, so why
not use this as an opportunity to replace it? See
https://github.com/es-tooling/module-replacements/blob/main/docs/modules/glob.md.

Compare the APIs:
- https://github.com/isaacs/node-glob#readme
- https://github.com/SuperchupuDev/tinyglobby?tab=readme-ov-file#api

The only differences are option names, which I've updated.

Our uses either hardcode patterns or enforce precisely documented user patterns, so we
won't hit any of the limitations of tinyglobby.
@serhalp serhalp self-assigned this Feb 18, 2025
@serhalp serhalp added the dependencies Pull requests that update a dependency file label Feb 18, 2025
@serhalp
Copy link
Contributor

serhalp commented Feb 18, 2025

Thanks @pythoncarpenter. Until recently, this printed three deprecation warnings! We were actually just about to look into this last one. I think I've got it with netlify/build#6094.

serhalp added a commit to netlify/build that referenced this issue Feb 18, 2025
@serhalp
fix(deps): replace deprecated glob@8
80b9666 
Installing netlify-cli prints a deprecation warning:
netlify/cli#7029.

I was going to upgrade `glob`, but then I remembered it's a fairly large library, so why
not use this as an opportunity to replace it? See
https://github.com/es-tooling/module-replacements/blob/main/docs/modules/glob.md.

Compare the APIs:
- https://github.com/isaacs/node-glob#readme
- https://github.com/SuperchupuDev/tinyglobby?tab=readme-ov-file#api

The only differences are option names, which I've updated.

Our uses either hardcode patterns or enforce precisely documented user patterns, so we
won't hit any of the limitations of tinyglobby.
@pythoncarpenter
Copy link
Author

Thanks so much 🙋‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@serhalp serhalp

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(deps): replace noisy deprecated glob@8 with tinyglobby netlify/build
2 participants
@pythoncarpenter @serhalp