Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable31] Fix npm audit #1874

Open
wants to merge 1 commit into
base: stable31
Choose a base branch
from

Conversation

nextcloud-command
Copy link
Contributor

@nextcloud-command nextcloud-command commented Feb 2, 2025

Audit report

This audit fix resolves 15 of the total 29 vulnerabilities found in your project.

Updated dependencies

Fixed vulnerabilities

@nextcloud/dialogs #

  • Caused by vulnerable dependency:
  • Affected versions: >=4.2.0-beta.1
  • Package usage:
    • node_modules/@nextcloud/dialogs

@nextcloud/l10n #

  • Caused by vulnerable dependency:
  • Affected versions: 1.1.0 - 3.1.0
  • Package usage:
    • node_modules/@nextcloud/l10n
    • node_modules/@nextcloud/moment/node_modules/@nextcloud/l10n

@nextcloud/moment #

  • Caused by vulnerable dependency:
  • Affected versions: >=1.1.1
  • Package usage:
    • node_modules/@nextcloud/moment

@testing-library/vue #

@vitest/coverage-v8 #

  • Caused by vulnerable dependency:
  • Affected versions: 2.0.0-beta.1 - 2.1.8
  • Package usage:
    • node_modules/@vitest/coverage-v8

@vue/test-utils #

  • Caused by vulnerable dependency:
  • Affected versions: <=1.3.6
  • Package usage:
    • node_modules/@vue/test-utils

dompurify #

  • DOMPurify allows Cross-site Scripting (XSS)
  • Severity: moderate (CVSS 4.5)
  • Reference: GHSA-vhxf-7vqr-mrjg
  • Affected versions: <3.2.4
  • Package usage:
    • node_modules/dompurify

elliptic #

  • Elliptic's private key extraction in ECDSA upon signing a malformed input (e.g. a string)
  • Severity: critical 🚨
  • Reference: GHSA-vjh7-7g9h-fjfh
  • Affected versions: <=6.6.0
  • Package usage:
    • node_modules/elliptic

nanoid #

  • Predictable results in nanoid generation when given non-integer values
  • Severity: moderate (CVSS 4.3)
  • Reference: GHSA-mwcw-c2x4-8c55
  • Affected versions: <3.3.8
  • Package usage:
    • node_modules/nanoid

node-gettext #

  • node-gettext vulnerable to Prototype Pollution
  • Severity: high (CVSS 5.9)
  • Reference: GHSA-g974-hxvm-x689
  • Affected versions: *
  • Package usage:
    • node_modules/node-gettext

vite #

  • Websites were able to send any requests to the development server and read the response in vite
  • Severity: moderate (CVSS 6.5)
  • Reference: GHSA-vg6x-rcgg-rjx6
  • Affected versions: 0.11.0 - 6.1.1
  • Package usage:
    • node_modules/vite

vitest #

  • Vitest allows Remote Code Execution when accessing a malicious website while Vitest API server is listening
  • Severity: critical 🚨 (CVSS 9.7)
  • Reference: GHSA-9crc-q9x8-hgqq
  • Affected versions: 2.0.0 - 2.1.8
  • Package usage:
    • node_modules/vitest

vue-resize #

  • Caused by vulnerable dependency:
  • Affected versions: 0.4.0 - 1.0.1
  • Package usage:
    • node_modules/vue-resize

vue-tsc #

  • Caused by vulnerable dependency:
  • Affected versions: 1.7.0-alpha.0 - 2.0.28
  • Package usage:
    • node_modules/vue-tsc

vuex #

  • Caused by vulnerable dependency:
  • Affected versions: 3.1.3 - 3.6.2
  • Package usage:
    • node_modules/vuex

@nextcloud-command nextcloud-command added 3. to review dependencies Pull requests that update a dependency file labels Feb 2, 2025
Copy link

codecov bot commented Feb 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.89%. Comparing base (ee229a5) to head (e129bf7).

Additional details and impacted files
@@             Coverage Diff              @@
##           stable31    #1874      +/-   ##
============================================
- Coverage     31.36%   30.89%   -0.48%     
============================================
  Files            43       43              
  Lines          1629     1615      -14     
  Branches        110      110              
============================================
- Hits            511      499      -12     
+ Misses         1092     1090       -2     
  Partials         26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Feb 2, 2025

Activity    Run #2201

Run Properties:  status check failed Failed #2201  •  git commit 5dfb2ad358: [stable31] Fix npm audit
Project Activity
Branch Review automated/noid/stable31-fix-npm-audit
Run status status check failed Failed #2201
Run duration 01m 11s
Commit git commit 5dfb2ad358: [stable31] Fix npm audit
Committer Nextcloud Command Bot
View all properties for this run ↗︎

Test results
Tests that failed  Failures 2
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 8
Tests that passed  Passing 0
View all changes introduced in this branch ↗︎

Tests for review

Failed  sidebar.cy.ts • 1 failed test • Run E2E

View Output

Test Artifacts
Check activity listing in the sidebar > Has creation activity Test Replay Screenshots
Failed  settings.cy.ts • 1 failed test • Run E2E

View Output

Test Artifacts
Check that user's settings survive a reload > Form survive a reload Test Replay Screenshots

@nextcloud-command nextcloud-command force-pushed the automated/noid/stable31-fix-npm-audit branch from 96501eb to 4ca7fe0 Compare February 9, 2025 03:18
@nextcloud-command nextcloud-command force-pushed the automated/noid/stable31-fix-npm-audit branch 2 times, most recently from d3aa2fc to dc343b0 Compare February 22, 2025 11:41
@nextcloud-command nextcloud-command force-pushed the automated/noid/stable31-fix-npm-audit branch from dc343b0 to e129bf7 Compare February 23, 2025 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant