Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better API for activity filters, settings and providers + Rich Object support #2092

Merged
merged 18 commits into from
Nov 16, 2016

Conversation

nickvergessen
Copy link
Member

Changes

  • Split the huge and non-understandable IExtension into three interfaces: IFilter, ISetting and IProvider
  • Allow to register filters via info.xml
  • Allow to register settings via info.xml
  • Allow to register provideres via info.xml
  • Adds support for Rich Object Strings ( Nextcloud Rich Object Strings #1706 ) to activities fixing the huge topic in the OC issues, so the clients can finally link file names and so on as well

Compatibility

  • Translations (Handled by activity app with a provider)
  • Old files/usernames in strings (Handled by activity app with a provider)
  • Settings (Handled by activity manager)
  • Filters (Handled by activity manager)

Breaking

  • Grouping of similar subsequent message (Todo for a second PR)
  • Icons of filters and events (URL vs. CSS class)
  • Direct SQL manipulation for filters (only usecase was favorites - functionality still available)

Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
@LukasReschke
Copy link
Member

👍 Awesome work! 🚀 👯 🍻

@rullzer
Copy link
Member

rullzer commented Nov 16, 2016

There was by no means a gun to my head.
But 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants