chore: session sum example #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
KeranYang
reviewed
Mar 25, 2024
Comment on lines
+142
to
+150
| var eofResponse *v1.ReduceResponse | ||
| for _, task := range rtm.tasks { | ||
| tasks = append(tasks, task) | ||
| } | ||
|
|
||
| for _, task := range tasks { | ||
| <-task.doneCh | ||
| if eofResponse == nil { | ||
| eofResponse = task.buildEOFResponse() | ||
| } | ||
| } | ||
| rtm.responseCh <- eofResponse | ||
|
|
There was a problem hiding this comment.
Is this a behaviour change? Before, each task, if not merged, sends its own EOFResponse to responseCh. After, when receiving an EOF, we loop through the active tasks and only send the last EOFResponse.
There was a problem hiding this comment.
I think we should include verifying EOF in our unit tests. Currently, we are not.
There was a problem hiding this comment.
I am approving as this is sort of urgent. We can address the unit test comment as a separate issue: #113
KeranYang
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #110