chore: stop hard coding quay.io image registry #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: a3hadi <[email protected]>
KeranYang
changed the title
KeranYang
reviewed
Jul 4, 2024
Signed-off-by: a3hadi <[email protected]>
|
I have asked @kohlisid to apply this change to batch map PR. We don't need to wait for it. I am approving and merging this PR. |
KeranYang
approved these changes
Jul 4, 2024
kohlisid
pushed a commit
that referenced
this pull request
Jul 8, 2024
Signed-off-by: a3hadi <[email protected]>
kohlisid
pushed a commit
that referenced
this pull request
Jul 8, 2024
Signed-off-by: a3hadi <[email protected]> Signed-off-by: Sidhant Kohli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge after #133 gets merged, so that we can add the same modifications to map batch example.