chore: shutdown when we see non retryable udf errors #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yashash H L <[email protected]>
KeranYang
reviewed
Nov 5, 2024
| err error | ||
| } | ||
|
|
||
| resultCh := make(chan recvResult, 1) |
There was a problem hiding this comment.
do we need this channel and the goroutine if we put stream.Recv inside select?
There was a problem hiding this comment.
We cannot do that since stream.Recv() is a blocking call.
| select { | ||
| case <-groupCtx.Done(): | ||
| req, err := recvWithContext(groupCtx, stream) | ||
| if errors.Is(err, context.Canceled) { |
There was a problem hiding this comment.
I see different behaviour between map and map batchmap above. batchmap is returning the err while map is breaking the outer loop without returning the err. Is this expected? same for map stream.
There was a problem hiding this comment.
Batchmap operations are invoked inside a separate function that is the reason we use return.
KeranYang
approved these changes
Nov 5, 2024
vigith
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.