Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SideInput sdk should also write ServerInfo #1457

Closed
4 tasks done
whynowy opened this issue Jan 13, 2024 · 2 comments · Fixed by #1488
Closed
4 tasks done

SideInput sdk should also write ServerInfo #1457

whynowy opened this issue Jan 13, 2024 · 2 comments · Fixed by #1488
Assignees
@ayildirim21
Labels
area/sdk area/side-inputs enhancement New feature or request good first issue Good for new contributors

Comments

@whynowy
Copy link
Member

whynowy commented Jan 13, 2024 •
edited by KeranYang
Loading

Summary

This will help on supporting backward compatibility later on.

Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

Tasks
Preview Give feedback
@vigith vigith added the good first issue Good for new contributors label Jan 16, 2024
@ayildirim21
Copy link
Member

I can pick this up

This was referenced Jan 23, 2024
Merged
Merged
Merged
@KeranYang
Copy link
Member

KeranYang commented Feb 1, 2024 •
edited
Loading

Re-opening as we need to also make changes on platform side. https://github.com/numaproj/numaflow/blob/main/pkg/sdkclient/sideinput/client.go#L24

@KeranYang KeranYang reopened this Feb 1, 2024
@ayildirim21 ayildirim21 mentioned this issue Feb 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ayildirim21 ayildirim21

Labels
area/sdk area/side-inputs enhancement New feature or request good first issue Good for new contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add serverinfo to sideinput on client side
4 participants
@vigith @whynowy @KeranYang @ayildirim21