chore: write server info for sideinput sdk #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: a3hadi <[email protected]>
KeranYang
changed the title
KeranYang
reviewed
Jan 23, 2024
There was a problem hiding this comment.
LGTM. Could you manually test it before merging?
I have renamed the commit. We follow a certain format to name a commit, usually starting with keyword like chore, fix, feat etc. see: https://github.com/numaproj/numaflow-go/commits/main/
It would be great if in the PR description you can add how this change was tested. For example, "I was able to deploy a pipeline with sideinput and saw the server info showed up in the sideinput container log".
yhl25
approved these changes
Jan 26, 2024
ayildirim21
added a commit
to ayildirim21/numaflow-go
that referenced
this pull request
Feb 7, 2024
Signed-off-by: a3hadi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements: Issue 1457 for the Go sdk