fix: man_pages on macOS 13 and FreeBSD #2326 #2352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macOS 13.x (Ventura, Darwin 22.x) uses `apropos(1)` from FreeBSD, which does not behave the same as the previous implementation up to macOS 12. `apropos(1)` takes a regular expression as an argument, so passing "." causes it to match anything and therefore return all results to be filtered by Telescope.
kkharji
approved these changes
Jan 29, 2023
There was a problem hiding this comment.
While testing, I came to found out that I haven't been using builtin man on macos at all :D (man-db + nix).
Everything works fine. But somehow I got back 4 extra entries with this fix, don't ask me what are they, haven't bothered 😆
Thanks @fschauen
|
Thanks for debugging and fixing this issue :) |
Conni2461
pushed a commit
that referenced
this pull request
Feb 19, 2023
macOS 13.x (Ventura, Darwin 22.x) uses `apropos(1)` from FreeBSD, which does not behave the same as the previous implementation up to macOS 12. `apropos(1)` takes a regular expression as an argument, so passing "." causes it to match anything and therefore return all results to be filtered by Telescope. (cherry picked from commit d5f6c09)
fschauen
added a commit
to fschauen/dotfiles
that referenced
this pull request
Jul 15, 2023
My PR that fixes it for everyone was merged :)
nvim-telescope/telescope.nvim#2352
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In macOS 13 (Ventura),
:Telescope man_pagesshows no results. This is caused by a difference in behavior between the previous implementation ofapropos(1)up to macOS 12.5 and the newmanpackage used in macOS 13, which comes from FreeBSD.This new
apropos(1)is implemented as a shell script and loses the" "argument through variable expansions. Sinceapropos(1)expects a regular expression to filter the results of thewhatisdatabase, passing"."causes it to not lose the argument and match everything, thus returning all results so they can be filtered within Telescope.In the process of investigating the root cause for the issue on macOS 13, I realized that
:Telescope man_pagesdoesn't work in FreeBSD for the same reason. Therefore, I included it in the fix.Fixes #2326
Type of change
How Has This Been Tested?
Test steps:
nvim(on either macOS 13 or FreeBSD).man_pagespicker with:Telescope man_pages.Configuration:
Checklist:
I have commented my code, particularly in hard-to-understand areas- not applicableI have made corresponding changes to the documentation (lua annotations)- not applicable