[azure] update authorization header with refreshed token during retry #1531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
| @@ -287,8 +287,7 @@ def _prepare_options(self, options: FinalRequestOptions) -> None: | |||
|
|
|||
| azure_ad_token = self._get_azure_ad_token() | |||
| if azure_ad_token is not None: | |||
| if headers.get("Authorization") is None: | |||
| headers["Authorization"] = f"Bearer {azure_ad_token}" | |||
| headers["Authorization"] = f"Bearer {azure_ad_token}" | |||
There was a problem hiding this comment.
I'm slightly nervous that this means we'll override any Authorization header that a user set which wouldn't be what they wanted.
I think we could restructure how this _prepare_options() method is called slightly to avoid this instead, I'll look into it.
There was a problem hiding this comment.
Put up a PR here: #1533
|
superceded by #1533 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes being requested
Upon a series of retry attempts, if the the token expires in the middle of it, the existing code is not updating the Authorization header with the refreshed token value.
Additional context & links
Related issue: #1526