Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing watch on prometheusrules and verb watch #1383

Merged
merged 1 commit into from
Nov 19, 2024
Merged

fix: missing watch on prometheusrules and verb watch #1383

merged 1 commit into from
Nov 19, 2024

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Nov 19, 2024

Description

to fix error:

E1118 18:36:29.170234       1 reflector.go:147] go/pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:229: Failed to watch *v1.PrometheusRule: unknown (get prometheusrules.monitoring.coreos.com)
E1118 18:36:32.323559       1 reflector.go:147] go/pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:229: Failed to watch *v1.PrometheusRule: unknown (get prometheusrules.monitoring.coreos.com)
E1118 18:36:35.841907       1 reflector.go:147] go/pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:229: Failed to watch *v1.PrometheusRule: unknown (get prometheusrules.monitoring.coreos.com)
E1118 18:36:47.923199       1 reflector.go:147] go/pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:229: Failed to watch *v1.PrometheusRule: unknown (get prometheusrules.monitoring.coreos.com)
E1118 18:37:00.767018       1 reflector.go:147] go/pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:229: Failed to watch *v1.PrometheusRule: unknown (get prometheusrules.monitoring.coreos.com)
E1118 18:37:49.838757       1 reflector.go:147] go/pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:229: Failed to watch *v1.PrometheusRule: unknown (get prometheusrules.monitoring.coreos.com)
E1118 18:38:26.132730       1 reflector.go:147] go/pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:229: Failed to watch *v1.PrometheusRule: unknown (get prometheusrules.monitoring.coreos.com)
E1118 18:39:16.681360       1 reflector.go:147] go/pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:229: Failed to watch *v1.PrometheusRule: unknown (get prometheusrules.monitoring.coreos.com)
E1118 18:40:07.333647       1 reflector.go:147] go/pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:229: Failed to watch console.openshift.io/v1, Kind=OdhQuickStart: unknown
E1118 18:40:08.032595       1 reflector.go:147] go/pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:229: Failed to watch dashboard.opendatahub.io/v1, Kind=OdhApplication: unknown
E1118 18:40:08.137744       1 reflector.go:147] go/pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:229: Failed to watch dashboard.opendatahub.io/v1, Kind=OdhDocument: unknown
E1118 18:40:09.038484       1 reflector.go:147] go/pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:229: Failed to watch console.openshift.io/v1, Kind=OdhQuickStart: unknown
E1118 18:40:09.136838       1 reflector.go:147] go/pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:229: Failed to watch dashboard.opendatahub.io/v1, Kind=OdhApplication: unknown
E1118 18:40:09.137036       1 reflector.go:147] go/pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:229: Failed to watch dashboard.opendatahub.io/v1, Kind=OdhDocument: unknown
E1118 18:40:11.734093       1 reflector.go:147] go/pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:229: Failed to watch console.openshift.io/v1, Kind=OdhQuickStart: unknown
E1118 18:40:12.038932       1 reflector.go:147] go/pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:229: Failed to watch dashboard.opendatahub.io/v1, Kind=OdhApplication: unknown

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

lburgazzoli
lburgazzoli reviewed Nov 19, 2024
View reviewed changes
main.go Outdated
@@ -232,6 +232,8 @@ func main() { //nolint:funlen,maintidx
},
// for prometheus and black-box deployment and ones we owns
&appsv1.Deployment{}: {Namespaces: deploymentCache},
// kueue need prometheusrules
&promv1.PrometheusRule{}: {},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since there's no specific config, is that actually needed ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i will need to add the same deploymentCache here

lburgazzoli
lburgazzoli reviewed Nov 19, 2024
View reviewed changes
bundle/manifests/opendatahub-operator.clusterserviceversion.yaml Outdated
@@ -114,7 +114,7 @@ metadata:
"trainingoperators.components.opendatahub.io", "trustyais.components.opendatahub.io", "workbenches.components.opendatahub.io"]'
operators.operatorframework.io/project_layout: go.kubebuilder.io/v3
repository: https://github.com/opendatahub-io/opendatahub-operator
name: opendatahub-operator.v2.19.0
name: opendatahub-operator.v2.21.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this expected ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i will revert

@openshift-ci openshift-ci bot added the lgtm label Nov 19, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lburgazzoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov Codecov
Copy link

codecov bot commented Nov 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (feature-operator-refactor@acd89b8). Learn more about missing BASE report.

Additional details and impacted files 
@@                     Coverage Diff                      @@
##             feature-operator-refactor    #1383   +/-   ##
============================================================
  Coverage                             ?   26.61%           
============================================================
  Files                                ?       55           
  Lines                                ?     4468           
  Branches                             ?        0           
============================================================
  Hits                                 ?     1189           
  Misses                               ?     3138           
  Partials                             ?      141

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@openshift-merge-bot openshift-merge-bot bot merged commit 77ba8e7 into opendatahub-io:feature-operator-refactor Nov 19, 2024
10 checks passed
This was referenced Dec 8, 2024
Closed
Closed
MarianMacik pushed a commit to MarianMacik/opendatahub-operator that referenced this pull request Jan 22, 2025
@rhods-devops-app
Merge pull request opendatahub-io#1383 from red-hat-data-services/kon…
bbc4eb1 
…flux/component-updates/odh-mlmd-grpc-server-v2-17

chore(deps): update odh-mlmd-grpc-server-v2-17 to 0ef806c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lburgazzoli lburgazzoli lburgazzoli approved these changes

@ajaypratap003 ajaypratap003 Awaiting requested review from ajaypratap003

Assignees

@lburgazzoli lburgazzoli

Labels
approved feature-operator-refactor lgtm
Projects
ODH Platform Planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zdtsw @lburgazzoli