apis: DSCInitialization: annotate ApplicationsNamespace with omitempty #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR can't be merged just yet 😢Please run For more info: https://github.com/opendatahub-io/opendatahub-operator/actions/runs/13032878021 |
|
/cc @lburgazzoli |
ykaliuta
force-pushed
the
empty-app-namespace
branch
3 times, most recently
from
f3ed875 to
bc0520b
Compare
Jira: https://issues.redhat.com/browse/RHOAIENG-18931 Api sets default value to opendatahub, but without "omitempty" in case of operator automatically creates DSCI (upgrade.go:CreateDefaultDSCI), the resulting object contains applicationsNamespace: "" and it's not defaulted by the api server causing then problems like ``` Namespace "" is invalid: metadata.name: Required value: name or generateName is required ``` The problem was triggered by removing default value for command line switch in the cleanup. Fixes: b0a0f87 ("update: clean up old code before refactor (opendatahub-io#1494)") Signed-off-by: Yauheni Kaliuta <[email protected]>
ykaliuta
force-pushed
the
empty-app-namespace
branch
from
bc0520b to
ddf85f0
Compare
zdtsw
approved these changes
Jan 29, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zdtsw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1585 +/- ##
=======================================
Coverage 19.98% 19.98%
=======================================
Files 159 159
Lines 10780 10780
=======================================
Hits 2154 2154
Misses 8396 8396
Partials 230 230 ☔ View full report in Codecov by Sentry. |
openshift-merge-bot
bot
merged commit 768539c
into
opendatahub-io:main
10 checks passed
zdtsw
pushed a commit
to zdtsw-forking/opendatahub-operator
that referenced
this pull request
Feb 3, 2025
opendatahub-io#1585) Jira: https://issues.redhat.com/browse/RHOAIENG-18931 Api sets default value to opendatahub, but without "omitempty" in case of operator automatically creates DSCI (upgrade.go:CreateDefaultDSCI), the resulting object contains applicationsNamespace: "" and it's not defaulted by the api server causing then problems like ``` Namespace "" is invalid: metadata.name: Required value: name or generateName is required ``` The problem was triggered by removing default value for command line switch in the cleanup. Fixes: b0a0f87 ("update: clean up old code before refactor (opendatahub-io#1494)") Signed-off-by: Yauheni Kaliuta <[email protected]> (cherry picked from commit 768539c)
openshift-merge-bot bot
pushed a commit
that referenced
this pull request
Feb 10, 2025
* chore: cleanup kustomize config (#1497) - suspend too many WARNING lines from "make bundle" - remove sample config for components and monitoring Signed-off-by: Wen Zhou <[email protected]> (cherry picked from commit 4fe5bed) * chore: add more rules in golint (#1487) - add rules for our API components and service which force alias to be named with suffix ctrl Signed-off-by: Wen Zhou <[email protected]> (cherry picked from commit 32d75a8) * update: clean up old code before refactor (#1494) * update: clean up old code before refactor - remove reference we explicilty check on odhdashboardconfig and kserve - remove customized config on controller QPS - remove RemoveLabel which is not called anywhere Signed-off-by: Wen Zhou <[email protected]> * update: - remove function for upgrade cleanup introduced before 2.8 - remove flags to main: operator namespace and application namespace ( operator namespace is passing as env variable, app namespace is done by DSCI ) Signed-off-by: Wen Zhou <[email protected]> * fix: Auth CR is cluster-scoped no need to set namespace for request - application namespace is removed from reconciler of dsci Signed-off-by: Wen Zhou <[email protected]> * fix: wrong code for upgrade path + rebase error Signed-off-by: Wen Zhou <[email protected]> --------- Signed-off-by: Wen Zhou <[email protected]> (cherry picked from commit b0a0f87) * docs: update workflow and how we use two branchs for ODH and downstream (#1582) * docs: update workflow and how we use two branchs for ODH and downstream - add new doc for how workflow, label on PR, sync process - update branch away from incubatin in github action and reference Signed-off-by: Wen Zhou <[email protected]> * Update docs/sync_code.md Co-authored-by: Gerard Ryan <[email protected]> * revert: branch related test config Signed-off-by: Wen Zhou <[email protected]> * fix: typo Signed-off-by: Wen Zhou <[email protected]> --------- Signed-off-by: Wen Zhou <[email protected]> Co-authored-by: Gerard Ryan <[email protected]> (cherry picked from commit da75d42) * update: platform team (#1583) Signed-off-by: Wen Zhou <[email protected]> (cherry picked from commit 46d8ba2) * Remove Sara4994 from OWNER_ALIASES (#1598) (cherry picked from commit bf8a6e2) * github: add branch into GHA for tests (#1593) Signed-off-by: Wen Zhou <[email protected]> (cherry picked from commit f4c932b) * apis: DSCInitialization: annotate ApplicationsNamespace with omitempty (#1585) Jira: https://issues.redhat.com/browse/RHOAIENG-18931 Api sets default value to opendatahub, but without "omitempty" in case of operator automatically creates DSCI (upgrade.go:CreateDefaultDSCI), the resulting object contains applicationsNamespace: "" and it's not defaulted by the api server causing then problems like ``` Namespace "" is invalid: metadata.name: Required value: name or generateName is required ``` The problem was triggered by removing default value for command line switch in the cleanup. Fixes: b0a0f87 ("update: clean up old code before refactor (#1494)") Signed-off-by: Yauheni Kaliuta <[email protected]> (cherry picked from commit 768539c) * regen bundle (#1602) (cherry picked from commit 2384ada) * test: prolong e2e in rhoai for 50mins Signed-off-by: Wen Zhou <[email protected]> * fix:default monitoring namespace Signed-off-by: Wen Zhou <[email protected]> --------- Signed-off-by: Wen Zhou <[email protected]> Co-authored-by: Ajay Jaganathan <[email protected]> Co-authored-by: Yauheni Kaliuta <[email protected]> Co-authored-by: Luca Burgazzoli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.redhat.com/browse/RHOAIENG-18931
Api sets default value to opendatahub, but without "omitempty" in
case of operator automatically creates DSCI (upgrade.go:CreateDefaultDSCI), the resulting object contains applicationsNamespace: "" and it's not defaulted by the api server causing then problems like
The problem was triggered by removing default value for command line switch in the cleanup.
Fixes: b0a0f87 ("update: clean up old code before refactor (#1494)")
Description
How Has This Been Tested?
Screenshot or short clip
Merge criteria