Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extraManifests type mismatch #32

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

marcuz
Copy link
Contributor

@marcuz marcuz commented Jan 7, 2025

Not setting any values for extraManifests broke chart installation process, because the type was invalid.

Before change:

$ helm lint charts/zipkin/
==> Linting charts/zipkin/
[INFO] Chart.yaml: icon is recommended
[ERROR] values.yaml: - extraManifests: Invalid type. Expected: object, given: array

[ERROR] templates/: values don't meet the specifications of the schema(s) in the following chart(s):
zipkin:
- extraManifests: Invalid type. Expected: object, given: array

After change:

$ helm lint charts/zipkin/
==> Linting charts/zipkin/
[INFO] Chart.yaml: icon is recommended

1 chart(s) linted, 0 chart(s) failed

@codefromthecrypt
Copy link
Member

sounds like adding helm lint to CI would be a welcome improvement

ps I think your master is a bit behind, hence the test fail. I'll merge anyway

@codefromthecrypt codefromthecrypt merged commit a757833 into openzipkin:master Jan 8, 2025
1 check failed
@marcuz marcuz mentioned this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants