-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add chinese document link into README #257
Conversation
@CafuChino love that there exists a Chinese translation for the project! Thank you so much for the work you've done on this For reference, this project is OSS and lives on @CafuChino's repo: https://github.com/CafuChino/plop-cn-doc (Notice the MIT license, which is important for us) That said, there are a few concerns I have:
Here's what I'm thinking, and I'd love your input on this (also wanting to CC @amwmedia) Looking at Vue's official docs, they have a dropdown in the top corner that displays languages they have support in: When clicking on the Chinese language, it brings you to a subdomain: https://cn.vuejs.org/index.html I'm wondering if we can't do the same thing with our official domain. Something like We'd certainly have to modify the code we're currently using to deploy, which lives at: https://github.com/plopjs/plopjs.com @amwmedia how feasible do you think it would be to deploy the site like that? I admittedly haven't dealt too much with subdomains in the past, but I know @evelynhathaway could probably help us figure that out (she's the person who's done deployments for a ton of my projects and is looking to get involved in maintaining Plop with us) Where are hosting the website? (DigitalOcean, GitHub Pages, etc?) |
I don't see why this would be a problem. The site is currently hosted on Netlify. I can easily create the subdomain and we could fork the existing plopjs.com repo to house the various translations. Maybe that's a good place to start? Just fork the website codebase to another repo that is Once we have the cn.plopjs.com site working, we can add the dropdown to both sites to allow users to jump from one to the other. Sound like a plan? |
Sounds good - I've got a busy week ahead of me, but I'll try to tackle sometime early next week |
Do you think it would be better to build translations into the website codebase itself instead of building multiple sites? I'd love to be able to build something that works well for Chinese and other languages, without incurring too much overhead. |
@CafuChino would you be willing to make a PR to this repo putting this data: https://github.com/CafuChino/plop-cn-doc Into a file called Once that is done, I will work on making a PR against the
@CafuChino I'd also like to offer to buy the |
Sorry for my late reply! I will work on it in a few days. At the same time, I am also happy to transfer this domain name for free 😺 |
@CafuChino you're amazing, thank you! ✨ Could you send me an email at |
chore: Add README.zh.md Related with #257
A Chinese version document site has been made based on VuePress, which will be very useful for Chinese developers.