-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user option for similarity measures #40
Conversation
When implementing a relative L1 norm for example, by which quantity do we divide? For example, we have the two simulation with states |
I see two options now:
|
Lets go for the second option, so dividing my the data value of one of the simulations. Which one to pick is our choice, we should only be consistent. As for vectorial quantities, lets say we have a quantity |
This should work now as we discussed, do we want unit tests for this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! These additions will expand the adaptivity functionality significantly. Minor changes from my side.
Co-authored-by: Ishaan Desai <[email protected]>
In the future we may want to switch to a different method of selecting functions. As suggested in #24, the user could provide their own similarity functions which cannot easily be realized with the string-selection. |
Do we want to merge this or wait for the documentation and the unit tests? Some documentation would be necessary for the similarity functions. |
Let me finish the documentation PR, and then we can add documentation here, and merge it. |
…er into similarity-functions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 only a few documentation related comments from my side. After adding the documentation we can merge.
Co-authored-by: Ishaan Desai <[email protected]>
Co-authored-by: Ishaan Desai <[email protected]>
Closes #24
This PR adds options for different similarity measures. Currently L1 and L2 are supported.