Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[68] Add additional flake8 checks #130

Merged
merged 3 commits into from
Apr 23, 2016
Merged

[68] Add additional flake8 checks #130

merged 3 commits into from
Apr 23, 2016

Conversation

elbenfreund
Copy link
Collaborator

This PR adds additional flake8 checks to ensure PEP8 compiience. It also contain minor fixes to errors found as a consequence.

Closes #68

@codecov-io
Copy link

Current coverage is 97.12%

Merging #130 into develop will not affect coverage as of 76638b2

@@            develop    #130   diff @@
=======================================
  Files             2       2       
  Stmts           348     348       
  Branches         31      31       
  Methods           0       0       
=======================================
  Hit             338     338       
  Partial           4       4       
  Missed            6       6

Review entire Coverage Diff as of 76638b2

Powered by Codecov. Updated on successful CI builds.

@elbenfreund
Add additional pep8 checks
fd5b9b0 
Added ``flake8-debugger``, ``flake8-print`` and ``flake8-naming`` to the
testsuit.

Closes #68
@elbenfreund
Make LOG_LEVELS a global variable.
0e8cd46 
Relates to #68
@elbenfreund
Fix testfunctions that included capital letters
76638b2 
Relates to #68
@elbenfreund elbenfreund force-pushed the feature/68-Add_additional_flake8_checks branch from b0292a4 to 76638b2 Compare April 23, 2016 09:08
@elbenfreund elbenfreund merged commit 76638b2 into develop Apr 23, 2016
@elbenfreund elbenfreund deleted the feature/68-Add_additional_flake8_checks branch April 23, 2016 09:16
elbenfreund added a commit that referenced this pull request Apr 25, 2016
@elbenfreund
Make sure our paths in fixtures contain utf8
21135e6 
In order to have confidence in our ability to handle utf8 path location
we just add random utf8 string named sub-dirs to our path fixtures.

We now have to wait for ``hamsterlib`` to fix #130

Closes: #106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add additionl flake8 checks
2 participants
@elbenfreund @codecov-io