[#130]Add test and fix for SA Engine repr failure #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running python 2, it apears SQLAlchemy is not fully capable to handle unicode strings as urls. While they can be passed and will be processed (correctly as far as we can tell) there are issues with 'representing' an ``Engine`` or ``sqlalchemy.engine.url.URL``. As far as we understand, their repr() call will naivly construct a str from its various components. If any of those substrings (like the URL) happens to be an unicode string, this will fail if it can not be ascii-decoded. SQLAlchemy should propably call repr(url) instead. For now, this commit just avoids the problem entirely by amending the triggering log message not to render a string representation of the created engine. A proper solution would probably be to write a custom wrapper function that handles Engine representation properly. Also, a test that triggers the origianl offending behaviour has been added, so any regression should be easier to find. Closes: #130
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running python 2, it apears SQLAlchemy is not fully capable to handle
unicode strings as urls. While they can be passed and will be processed
(correctly as far as we can tell) there are issues with 'representing'
an
Engineorsqlalchemy.engine.url.URL. As far as we understand,their
repr()call will naivly construct astrfrom its variouscomponents. If any of those substrings (like the URL) happens to be an
unicode string, this will fail if it can not be ascii-decoded.
SQLAlchemy should propably call repr(url) instead.
For now, this commit just avoids the problem entirely by amending the
triggering log message not to render a string representation of the
created engine. A proper solution would probably be to write a custom
wrapper function that handles Engine representation properly.
Also, a test that triggers the origianl offending behaviour has been
added, so any regression should be easier to find.
Closes: #130