Allow multiple REstate host instances #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make REstateHost a singleton, but hide that from users - Add Agent() extension method since you cant have a static and instance member with the same name - Shift around properties to make this work - 🔥 Remove ResetAgent grossness
aidapsibr
force-pushed
the
AllowMultipeHostInstances
branch
from
15de7e0 to
22f4bfe
Compare
- Add test for REstateHost to ensure the static API still works.
aidapsibr
commented
Dec 23, 2017
| @@ -225,7 +225,7 @@ public void CanBuildServerServiceDefinition() | |||
| } | |||
|
|
|||
| [Fact] | |||
| public async Task CreateMachineFromStoreAsync() | |||
| public async Task MachineFromStoreAsync() | |||
aidapsibr
force-pushed
the
AllowMultipeHostInstances
branch
from
22f4bfe to
6b5e421
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Allows for multiple instance of REstate Host in addition to the static API (which is now a singleton).
Alternate Designs
Why Should This Be In Core?
Needed for test cases.
Benefits
Will be beneficial in the future where a developer needs multiple hosts as would be the case with multiple, but different, Remote hosts and repositories.
Possible Drawbacks
Applicable Issues