-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IMU_USE_SPI_ICM45686 #37
base: main
Are you sure you want to change the base?
Conversation
Hey @vidma, that starts to look like something! Please submit the MPU9250 fix as a separate PR, then we can get that one in already. Apparently WAI 0x73 is MPU9255 and 0x71 is MPU9250. Did you test with a MPU9255 ? |
This reverts commit 1e091df.
|
@qqqlab ready for review.
|
Hi @vidma Thanks for your hard work on this, I really appreciate it. It looks fine to me, and I'll merge it. But, as I don't have this sensor I can't test it... So ideally: fly it before we merge it :-) Currently madflight is single IMU only, so lack of multiple instances is not an issue. I would still prefer that you copy-paste the fixed TDK sources into this PR:
|
for #35 #36
ICM45686
is a dependency to have a smaller PR. I'm not sure if it's a very good idea to copy-paste code from there, as there's many interdependent include/extern files there, but, as we need some bugfix patches there, already implemented "copy-paste" as separate PRmodification, are permitted provided that the following conditions are met:
must retain the above copyright notice
Redistributions in binary form must reproduce the above copyright notice