Merge pull request #131 from forresty/presence/square-bracket

presence cop: fix [] for ternary expr other hand
rubocop · Oct 13, 2019 · 048463f · 048463f
2 parents 2922567 + 21a3285
commit 048463f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lib/rubocop/cop/rails/presence.rb b/lib/rubocop/cop/rails/presence.rb
@@ -129,7 +129,7 @@ def replacement(receiver, other)
         end
 
         def build_source_for_or_method(other)
-          if other.parenthesized? || !other.arguments?
+          if other.parenthesized? || other.method?('[]') || !other.arguments?
             " || #{other.source}"
           else
             method = range_between(

diff --git a/spec/rubocop/cop/rails/presence_spec.rb b/spec/rubocop/cop/rails/presence_spec.rb
@@ -44,6 +44,11 @@
                   'a(:bar).map(&:baz).presence',
                   1, 1
 
+  it_behaves_like 'offense',
+                  'a.present? ? a : b[:c]',
+                  'a.presence || b[:c]',
+                  1, 1
+
   it_behaves_like 'offense', <<~RUBY.chomp, 'a.presence', 1, 5
     if a.present?
       a