We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reference: https://rails.rubystyle.guide/#http-status-code-symbols
If I have the following code:
# frozen_string_literal: true class ProductsController < ApplicationController def index render status: '403' end end
or
# frozen_string_literal: true class ProductsController < ApplicationController def index render status: 'forbidden' end end
I will run rubocop and not get any offences:
ydakuka@yauhenid:~/Work/project$ bin/rails_docker rubocop app/controllers/products_controller.rb Inspecting 1 file . 1 file inspected, no offenses detected
# frozen_string_literal: true class ProductsController < ApplicationController def index render status: :forbidden end end
ydakuka@yauhenid:~/Work/project$ bin/rails_docker rubocop -V 1.55.1 (using Parser 3.2.2.3, rubocop-ast 1.29.0, running on ruby 2.7.8) [x86_64-linux] - rubocop-capybara 2.18.0 - rubocop-factory_bot 2.23.1 - rubocop-performance 1.18.0 - rubocop-rails 2.20.2 - rubocop-rake 0.6.0 - rubocop-rspec 2.23.0 - rubocop-thread_safety 0.5.1
The text was updated successfully, but these errors were encountered:
render status: 'forbidden' does not seem to be a valid argument compatible with the symbol argument, so it probably shouldn't be detected.
render status: 'forbidden'
Sorry, something went wrong.
[Fix rubocop#1080] Make Rails/HttpStatus aware of string number status
Rails/HttpStatus
411d119
Resolves rubocop#1080. This PR makes `Rails/HttpStatus` aware of string number status.
Merge pull request #1101 from koic/make_rails_http_status_aware_of_st…
baf39e6
…ring_number_status [Fix #1080] Make `Rails/HttpStatus` aware of string number status
Successfully merging a pull request may close this issue.
Reference: https://rails.rubystyle.guide/#http-status-code-symbols
Actual behavior
If I have the following code:
or
I will run rubocop and not get any offences:
Expected behavior
Rubocop
ydakuka@yauhenid:~/Work/project$ bin/rails_docker rubocop -V 1.55.1 (using Parser 3.2.2.3, rubocop-ast 1.29.0, running on ruby 2.7.8) [x86_64-linux] - rubocop-capybara 2.18.0 - rubocop-factory_bot 2.23.1 - rubocop-performance 1.18.0 - rubocop-rails 2.20.2 - rubocop-rake 0.6.0 - rubocop-rspec 2.23.0 - rubocop-thread_safety 0.5.1
The text was updated successfully, but these errors were encountered: