Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rails/RelativeDateConstant crashes #559

Closed
ccutrer opened this issue Sep 23, 2021 · 0 comments · Fixed by #560
Closed

Rails/RelativeDateConstant crashes #559

ccutrer opened this issue Sep 23, 2021 · 0 comments · Fixed by #560
Labels
bug Something isn't working

Comments

@ccutrer
Copy link
Contributor

ccutrer commented Sep 23, 2021 •
edited
Loading

I'm getting some errors running RuboCop against some code. Details below.

Expected behavior

RuboCop doesn't give an error.

Actual behavior

For /Users/cody/src/canvas-lms: configuration from /Users/cody/src/canvas-lms/.rubocop.yml
Inheriting configuration from /Users/cody/src/canvas-lms/.rubocop.common.yml
configuration from /Users/cody/.gem/ruby/2.7.2/gems/rubocop-rails-2.12.2/config/default.yml
configuration from /Users/cody/.gem/ruby/2.7.2/gems/rubocop-rails-2.12.2/config/default.yml
Default configuration from /Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/config/default.yml
configuration from /Users/cody/.gem/ruby/2.7.2/gems/rubocop-rake-0.6.0/config/default.yml
configuration from /Users/cody/.gem/ruby/2.7.2/gems/rubocop-rake-0.6.0/config/default.yml
configuration from /Users/cody/.gem/ruby/2.7.2/gems/rubocop-rspec-2.5.0/config/default.yml
configuration from /Users/cody/.gem/ruby/2.7.2/gems/rubocop-rspec-2.5.0/config/default.yml
configuration from /Users/cody/.gem/ruby/2.7.2/gems/rubocop-performance-1.11.5/config/default.yml
configuration from /Users/cody/.gem/ruby/2.7.2/gems/rubocop-performance-1.11.5/config/default.yml
warning: parser/current is loading parser/ruby27, which recognizes
warning: 2.7.4-compliant syntax, but you are running 2.7.2.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.
configuration from /Users/cody/src/canvas-lms/gems/rubocop-canvas/config/default.yml
Use parallel by default.
Running parallel inspection
An error occurred while Rails/RelativeDateConstant cop was inspecting /Users/cody/src/canvas-lms/app/models/user_profile.rb:39:2.
undefined method `block_type?' for nil:NilClass
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-rails-2.12.2/lib/rubocop/cop/rails/relative_date_constant.rb:93:in `nested_relative_date'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-rails-2.12.2/lib/rubocop/cop/rails/relative_date_constant.rb:54:in `block in on_masgn'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-rails-2.12.2/lib/rubocop/cop/rails/relative_date_constant.rb:51:in `each'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-rails-2.12.2/lib/rubocop/cop/rails/relative_date_constant.rb:51:in `on_masgn'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/cop/commissioner.rb:100:in `public_send'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/cop/commissioner.rb:100:in `block (2 levels) in trigger_responding_cops'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/cop/commissioner.rb:160:in `with_cop_error_handling'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/cop/commissioner.rb:99:in `block in trigger_responding_cops'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/cop/commissioner.rb:98:in `each'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/cop/commissioner.rb:98:in `trigger_responding_cops'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/cop/commissioner.rb:69:in `on_masgn'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-ast-1.11.0/lib/rubocop/ast/traversal.rb:137:in `block in on_dstr'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-ast-1.11.0/lib/rubocop/ast/traversal.rb:137:in `each'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-ast-1.11.0/lib/rubocop/ast/traversal.rb:137:in `on_dstr'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/cop/commissioner.rb:71:in `on_begin'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-ast-1.11.0/lib/rubocop/ast/traversal.rb:154:in `on_class'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/cop/commissioner.rb:71:in `on_class'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-ast-1.11.0/lib/rubocop/ast/traversal.rb:137:in `block in on_dstr'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-ast-1.11.0/lib/rubocop/ast/traversal.rb:137:in `each'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-ast-1.11.0/lib/rubocop/ast/traversal.rb:137:in `on_dstr'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/cop/commissioner.rb:71:in `on_begin'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-ast-1.11.0/lib/rubocop/ast/traversal.rb:20:in `walk'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/cop/commissioner.rb:86:in `investigate'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/cop/team.rb:155:in `investigate_partial'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/cop/team.rb:83:in `investigate'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/runner.rb:309:in `inspect_file'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/runner.rb:253:in `block in do_inspection_loop'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/runner.rb:287:in `block in iterate_until_no_changes'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/runner.rb:280:in `loop'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/runner.rb:280:in `iterate_until_no_changes'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/runner.rb:249:in `do_inspection_loop'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/runner.rb:130:in `block in file_offenses'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/runner.rb:155:in `file_offense_cache'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/runner.rb:129:in `file_offenses'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/runner.rb:67:in `block in warm_cache'
/Users/cody/.gem/ruby/2.7.2/gems/parallel-1.21.0/lib/parallel.rb:515:in `call_with_index'
/Users/cody/.gem/ruby/2.7.2/gems/parallel-1.21.0/lib/parallel.rb:485:in `process_incoming_jobs'
/Users/cody/.gem/ruby/2.7.2/gems/parallel-1.21.0/lib/parallel.rb:465:in `block in worker'
/Users/cody/.gem/ruby/2.7.2/gems/parallel-1.21.0/lib/parallel.rb:456:in `fork'
/Users/cody/.gem/ruby/2.7.2/gems/parallel-1.21.0/lib/parallel.rb:456:in `worker'
/Users/cody/.gem/ruby/2.7.2/gems/parallel-1.21.0/lib/parallel.rb:447:in `block in create_workers'
/Users/cody/.gem/ruby/2.7.2/gems/parallel-1.21.0/lib/parallel.rb:446:in `each'
/Users/cody/.gem/ruby/2.7.2/gems/parallel-1.21.0/lib/parallel.rb:446:in `each_with_index'
/Users/cody/.gem/ruby/2.7.2/gems/parallel-1.21.0/lib/parallel.rb:446:in `create_workers'
/Users/cody/.gem/ruby/2.7.2/gems/parallel-1.21.0/lib/parallel.rb:386:in `work_in_processes'
/Users/cody/.gem/ruby/2.7.2/gems/parallel-1.21.0/lib/parallel.rb:289:in `map'
/Users/cody/.gem/ruby/2.7.2/gems/parallel-1.21.0/lib/parallel.rb:238:in `each'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/runner.rb:67:in `warm_cache'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/runner.rb:46:in `run'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/cli/command/execute_runner.rb:26:in `block in execute_runner'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/cli/command/execute_runner.rb:52:in `with_redirect'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/cli/command/execute_runner.rb:25:in `execute_runner'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/cli/command/execute_runner.rb:17:in `run'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/cli/command.rb:11:in `run'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/cli/environment.rb:18:in `run'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/cli.rb:71:in `run_command'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/cli.rb:78:in `execute_runners'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/cli.rb:47:in `run'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/exe/rubocop:12:in `block in <top (required)>'
/Users/cody/.rubies/ruby-2.7.2/lib/ruby/2.7.0/benchmark.rb:308:in `realtime'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/exe/rubocop:12:in `<top (required)>'
/Users/cody/.gem/ruby/2.7.2/bin/rubocop:23:in `load'
/Users/cody/.gem/ruby/2.7.2/bin/rubocop:23:in `<main>'
Inspecting 1 file
Scanning /Users/cody/src/canvas-lms/app/models/user_profile.rb
An error occurred while Rails/RelativeDateConstant cop was inspecting /Users/cody/src/canvas-lms/app/models/user_profile.rb:39:2.
undefined method `block_type?' for nil:NilClass
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-rails-2.12.2/lib/rubocop/cop/rails/relative_date_constant.rb:93:in `nested_relative_date'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-rails-2.12.2/lib/rubocop/cop/rails/relative_date_constant.rb:54:in `block in on_masgn'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-rails-2.12.2/lib/rubocop/cop/rails/relative_date_constant.rb:51:in `each'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-rails-2.12.2/lib/rubocop/cop/rails/relative_date_constant.rb:51:in `on_masgn'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/cop/commissioner.rb:100:in `public_send'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/cop/commissioner.rb:100:in `block (2 levels) in trigger_responding_cops'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/cop/commissioner.rb:160:in `with_cop_error_handling'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/cop/commissioner.rb:99:in `block in trigger_responding_cops'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/cop/commissioner.rb:98:in `each'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/cop/commissioner.rb:98:in `trigger_responding_cops'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/cop/commissioner.rb:69:in `on_masgn'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-ast-1.11.0/lib/rubocop/ast/traversal.rb:137:in `block in on_dstr'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-ast-1.11.0/lib/rubocop/ast/traversal.rb:137:in `each'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-ast-1.11.0/lib/rubocop/ast/traversal.rb:137:in `on_dstr'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/cop/commissioner.rb:71:in `on_begin'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-ast-1.11.0/lib/rubocop/ast/traversal.rb:154:in `on_class'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/cop/commissioner.rb:71:in `on_class'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-ast-1.11.0/lib/rubocop/ast/traversal.rb:137:in `block in on_dstr'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-ast-1.11.0/lib/rubocop/ast/traversal.rb:137:in `each'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-ast-1.11.0/lib/rubocop/ast/traversal.rb:137:in `on_dstr'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/cop/commissioner.rb:71:in `on_begin'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-ast-1.11.0/lib/rubocop/ast/traversal.rb:20:in `walk'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/cop/commissioner.rb:86:in `investigate'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/cop/team.rb:155:in `investigate_partial'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/cop/team.rb:83:in `investigate'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/runner.rb:309:in `inspect_file'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/runner.rb:253:in `block in do_inspection_loop'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/runner.rb:287:in `block in iterate_until_no_changes'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/runner.rb:280:in `loop'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/runner.rb:280:in `iterate_until_no_changes'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/runner.rb:249:in `do_inspection_loop'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/runner.rb:130:in `block in file_offenses'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/runner.rb:155:in `file_offense_cache'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/runner.rb:129:in `file_offenses'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/runner.rb:120:in `process_file'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/runner.rb:101:in `block in each_inspected_file'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/runner.rb:100:in `each'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/runner.rb:100:in `reduce'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/runner.rb:100:in `each_inspected_file'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/runner.rb:86:in `inspect_files'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/runner.rb:47:in `run'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/cli/command/execute_runner.rb:26:in `block in execute_runner'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/cli/command/execute_runner.rb:52:in `with_redirect'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/cli/command/execute_runner.rb:25:in `execute_runner'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/cli/command/execute_runner.rb:17:in `run'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/cli/command.rb:11:in `run'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/cli/environment.rb:18:in `run'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/cli.rb:71:in `run_command'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/cli.rb:78:in `execute_runners'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/lib/rubocop/cli.rb:47:in `run'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/exe/rubocop:12:in `block in <top (required)>'
/Users/cody/.rubies/ruby-2.7.2/lib/ruby/2.7.0/benchmark.rb:308:in `realtime'
/Users/cody/.gem/ruby/2.7.2/gems/rubocop-1.21.0/exe/rubocop:12:in `<top (required)>'
/Users/cody/.gem/ruby/2.7.2/bin/rubocop:23:in `load'
/Users/cody/.gem/ruby/2.7.2/bin/rubocop:23:in `<main>'
.

1 file inspected, no offenses detected

1 error occurred:
An error occurred while Rails/RelativeDateConstant cop was inspecting /Users/cody/src/canvas-lms/app/models/user_profile.rb:39:2.
Errors are usually caused by RuboCop bugs.
Please, report your problems to RuboCop's issue tracker.
https://github.com/rubocop/rubocop/issues

Mention the following information in the issue report:
1.21.0 (using Parser 3.0.2.0, rubocop-ast 1.11.0, running on ruby 2.7.2 x86_64-darwin20)
Finished in 1.3512940000000526 second

Steps to reproduce the problem

rubocop --only Rails/RelativeDateConstant -d -- app/models/user_profile.rb

The file in question is https://github.com/instructure/canvas-lms/blob/725711463b386ce54e91032518ffaa6c8b8d0188/app/models/user_profile.rb

RuboCop version

1.21.0 (using Parser 3.0.2.0, rubocop-ast 1.11.0, running on ruby 2.7.2 x86_64-darwin20)
  - rubocop-performance 1.11.5
  - rubocop-rails 2.12.2
  - rubocop-rake 0.6.0
  - rubocop-rspec 2.5.0
@koic koic added the bug Something isn't working label Sep 23, 2021
koic added a commit to koic/rubocop-rails that referenced this issue Sep 23, 2021
@koic
[Fix rubocop#559] Fix an error for Rails/RelativeDateConstant
bc09f78 
Fixes rubocop#559.

This PR fixes an error for `Rails/RelativeDateConstant`
when using multiple assignment.
@koic koic mentioned this issue Sep 23, 2021
Merged
9 tasks
koic added a commit to koic/rubocop-rails that referenced this issue Sep 23, 2021
@koic
[Fix rubocop#559] Fix an error for Rails/RelativeDateConstant
0e2a2f4 
Fixes rubocop#559.

This PR fixes an error for `Rails/RelativeDateConstant`
when using multiple assignment.
@koic koic closed this as completed in #560 Sep 26, 2021
koic added a commit that referenced this issue Sep 26, 2021
@koic
Merge pull request #560 from koic/fix_error_for_rails_relative_date_c…
48a9448 
…onstant

[Fix #559] Fix an error for `Rails/RelativeDateConstant`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix #559] Fix an error for Rails/RelativeDateConstant koic/rubocop-rails
2 participants
@koic @ccutrer