False positive on Rails/ResponseParsedBody

[jcoyne]

I'm seeing this error:

spec/controllers/spotlight/catalog_controller_spec.rb:308:16: C: [Correctable] Rails/ResponseParsedBody: Prefer response.parsed_body to JSON.parse(response.body).
        data = JSON.parse(response.body).with_indifferent_access
               ^^^^^^^^^^^^^^^^^^^^^^^^^

However I can not autocorrect this as parsed_body only works in the case that there is a parser found for the corresponding mime type. https://api.rubyonrails.org/classes/ActionDispatch/TestResponse.html#method-i-parsed_body

My response doesn't have one:

response.content_type
"application/solr+json; charset=utf-8"

So this cop depends on the assumption that the request has a mime-type of application/json, which isn't going to be true for all cases.

[vlad-pisanov]

Autocorrect is marked unsafe for this very reason: https://docs.rubocop.org/rubocop-rails/cops_rails.html#safety-27

This cop’s autocorrection is unsafe because Content-Type may not be application/json

A potential workaround is to register a JSON encoder for your custom content-type for your test suite:

ActionDispatch::RequestEncoder.register_encoder :jsonapi, response_parser: ->(body) { JSON.parse(body) }