-
-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix create_table with multi t columns for Rails/SchemaComment
#1042
Fix create_table with multi t columns for Rails/SchemaComment
#1042
Conversation
7565c92
to
bb66f21
Compare
^^^^^^^^^^^^^^^^^^^^^^^^^^ New database column without `comment`. | ||
t.column :column1, :integer, comment: 'I am a first column' | ||
t.column :column2, :integer | ||
^^^^^^^^^^^^^^^^^^^^^^^^^^^ New database column without `comment`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you write a new test case without directly editing the existing test case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I wrote two new test cases.
^^^^^^^^^^^^^^^^^ New database column without `comment`. | ||
t.integer :column1, comment: 'I am a first column' | ||
t.integer :column2 | ||
^^^^^^^^^^^^^^^^^^ New database column without `comment`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto.
@nipe0324 This looks good to me. Can you squash your commits into one? |
2cca970
to
91e2e3e
Compare
@koic Ok, I have squashed my commits into one. |
Thanks! |
This PR is fix no offenses for
Rails/SchemaComment
.Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.