-
-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rails/SafeNavigationWithBlank cop #133
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Nov 8, 2019
koic
reviewed
Nov 8, 2019
koic
reviewed
Nov 8, 2019
koic
reviewed
Nov 8, 2019
4ed4fb3
to
5ee1d23
Compare
@koic Thanks a lot for the review! I fixed the obvious remarks and also took a shot at implementing autocorrect for the cop - during that, I also fixed the pattern matcher a bit (I think it was wrong before). Let me know if I can do more on this PR! |
koic
reviewed
Nov 11, 2019
cf22223
to
0a4e377
Compare
0a4e377
to
35b9cc0
Compare
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
Rails/SafeNavigatinoWithBlank
cop.It's a clone of the base Ruby cop Lint/SafeNavigationWithEmpty updated for
.blank?
in Rails, which has the same issue.It's up for discussion if the cop should cover all usages of safe operator
&.
and.blank?
, and not be limited only to conditionals. This could also be an option of the cop.Before submitting the PR make sure the following are checked:
Commit message starts with[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default
. It executes all tests and RuboCop for itself, and generates the documentation.