Add new Rails/PluckInWhere cop
#269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
reviewed
Jun 26, 2020
fatkodima
force-pushed
the
pluck_in_where-cop
branch
from
be310e1 to
65bcce7
Compare
koic
reviewed
Jun 28, 2020
fatkodima
force-pushed
the
pluck_in_where-cop
branch
from
65bcce7 to
28ee6b8
Compare
|
Updated. |
koic
reviewed
Jun 28, 2020
koic
reviewed
Jun 28, 2020
koic
reviewed
Jun 28, 2020
|
|
||
| def in_where?(node) | ||
| send_node = node.each_ancestor(:send).first | ||
| WHERE_METHODS.include?(send_node&.method_name) |
There was a problem hiding this comment.
Why are safe navigation operator (&.) used?
There was a problem hiding this comment.
pluck can be not within other send node, so send_node can be nil.
I rewrote this line without & to make it a little bit clear.
fatkodima
force-pushed
the
pluck_in_where-cop
branch
from
28ee6b8 to
f0a5fbc
Compare
|
Updated. |
|
Thank you! 👍 |
|
Thank you @fatkodima! Excellent to see and learn from this PR! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #246
This pattern is very common and I have seen its usage a lot of times.
Maybe there are other places where
pluckcan be replaced withselect, but inwhere- is the most common one I can think of right now.