Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #546] Exclude app/models by default for Rails/ContentTag #549

Merged

Conversation

koic
Copy link
Member

@koic koic commented Sep 14, 2021

Fixes #546

This PR excludes app/models by default for Rails/ContentTag. Because it prevents false positives for tag calls to has_one: tag. No helpers are used in normal models.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

Fixes rubocop#546

This PR excludes `app/models` by default for `Rails/ContentTag`.
Because it prevents false positives for `tag` calls to `has_one: tag`.
No helpers are used in normal models.
@koic koic force-pushed the exclude_models_by_default_for_rails_content_tag branch from 47f7993 to 2512108 Compare September 14, 2021 03:01
@koic koic merged commit 7570fb6 into rubocop:master Sep 14, 2021
@koic koic deleted the exclude_models_by_default_for_rails_content_tag branch September 14, 2021 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rails/ContentTag makes rubocop crashes
1 participant