[Fix #694] Mark Rails/FindEach as unsafe
#972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rubocop#694 and rubocop#397. This PR marks `Rails/FindEach` as unsafe.
koic
force-pushed
the
mark_rails_find_each_as_unsafe
branch
from
a63dfe2 to
f5aa590
Compare
franzliedke
reviewed
Sep 13, 2023
| # @safety | ||
| # This cop is unsafe if the receiver object is not an Active Record object. | ||
| # Also, `all.each` returns an `Array` instance and `all.find_each` returns nil, | ||
| # so the return values are different. |
There was a problem hiding this comment.
@koic I noticed there's also another case, which is the presence/absence of ordering, and whether one can order by primary key. (That's only relevant when you start batching.)
Should that be added as well?
There was a problem hiding this comment.
We have ActiveRecords with nil primary keys and replacing each with find_each on these broke our queries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #694 and #397.
This PR marks
Rails/FindEachas unsafe.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.