Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that the start_offset <= end_offset for all locations #902

Merged
merged 1 commit into from
May 16, 2023
Merged

Check that the start_offset <= end_offset for all locations #902

merged 1 commit into from
May 16, 2023

Conversation

eregon
Copy link
Member

@eregon eregon commented Apr 24, 2023

This shows clearly where it does not hold and gives more context.

@eregon eregon mentioned this pull request Apr 24, 2023
Closed
@eregon eregon linked an issue Apr 24, 2023 that may be closed by this pull request
Assert start <= end for all locations in snapshots #891
Closed
@eregon eregon mentioned this pull request Apr 24, 2023
Merged
@eregon
Copy link
Member Author

eregon commented Apr 24, 2023

Failures can be seen at https://github.com/Shopify/yarp/actions/runs/4790229653/jobs/8519067347?pr=902#step:5:33

@haldun
Copy link
Collaborator

haldun commented May 8, 2023

@eregon As of 37439a5 there should be no failing tests i.e. there are no cases where location start > location end.

@eregon eregon force-pushed the check-start-offset-lte-end-offset branch from 8360609 to a3ef03b Compare May 14, 2023 12:15
@eregon
Copy link
Member Author

eregon commented May 14, 2023

Awesome! I rebase this PR and mark it ready for review/merge then.

@eregon eregon marked this pull request as ready for review May 14, 2023 12:17
@eregon eregon requested a review from jemmaissroff May 14, 2023 12:18
jemmaissroff
jemmaissroff approved these changes May 16, 2023
View reviewed changes
Copy link
Collaborator

@jemmaissroff jemmaissroff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @eregon and @haldun!

jemmaissroff
jemmaissroff approved these changes May 16, 2023
View reviewed changes
Copy link
Collaborator

@jemmaissroff jemmaissroff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @eregon and @haldun!

@jemmaissroff jemmaissroff merged commit 626f1f5 into ruby:main May 16, 2023
@eregon eregon deleted the check-start-offset-lte-end-offset branch May 19, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jemmaissroff jemmaissroff jemmaissroff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assert start <= end for all locations in snapshots
3 participants
@eregon @haldun @jemmaissroff