Add length() and endOffset() to migrate to (startOffset, length) in a compatible way #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* To avoid a conflict with `length = endOffset - startOffset`.
|
Corresponding TruffleRuby PR: oracle/truffleruby#3081 BTW in this case since it was easy to not break the job I did it, but I think it's totally fine to break it if we know how to fix it and there is no easy way to do it in a non-breaking manner (e.g., renaming a node class or a node field). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #872
By adding these methods, and TruffleRuby migrating to them, we can avoid breaking the
Test Loader.java with TruffleRubyCI job.