Store length instead of endOffset in Java and Ruby objects #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready for review/merge. |
kddnewton
approved these changes
Jun 1, 2023
lib/yarp.rb
Outdated
| end | ||
|
|
||
| def deconstruct_keys(keys) | ||
| { start_offset: start_offset, end_offset: end_offset } | ||
| { start_offset: start_offset, end_offset: end_offset } # TODO |
There was a problem hiding this comment.
I was wondering if we should change the deconstruct_keys to include length instead of end_offset.
But it doesn't seem so useful and things like pretty_print should still show the end_offset as that seems more readable, and would be noisy to change.
I'll just remove it, I can try it later and see whether that makes sense.
eregon
force-pushed
the
length-instead-of-endOffset
branch
from
daf5a17 to
f7b7bc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #872