Fix typos in the external-symbols feature(bug) #199
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This was introduced in #169
There was a typo in some of the feature gates from
external-symbols
toexternal_symbols
.it wasn't caught because it was either not
pub extern "C"
(likesecp256k1_context_create
) or prefixed with therustsecp256k1_v0_1_1_*
which made it not collide with other symbols.Second thing is we still have some leftovers from the
dont_replace_c_symbols
feature (#177) which we no longer support since #169 was merged and prefixed all the symbols so they're not really easily usable in C/C++ code anyway.this feature isn't in our Cargo.toml anyway so these are no-ops anyway now.