fix: Calculate the privacy of dependencies wrt current local crate #137441
+114
−55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially mitigates #119428
This PR addresses most aspects of the issue, except for the following cases:
For example, consider the following cases:
rust/tests/ui/privacy/pub-priv-dep/shared_direct_private.rs
Lines 26 to 33 in 15469f8
rust/tests/ui/privacy/pub-priv-dep/diamond_deps.rs
Lines 32 to 33 in 15469f8
Resolving the remaining issue likely requires modifying the path lowering logic. I plan to work on that in a follow-up PR—assuming, of course, that this one gets merged first! 😅
P.S. I'd also appreciate a review on #134176 😊