fix read/write when input slice is empty #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreeaflorescu
requested review from
alexandruag,
bonzini and
jiangliu
as code owners
jiangliu
previously approved these changes
Feb 21, 2022
andreeaflorescu
commented
Feb 21, 2022
andreeaflorescu
force-pushed
the
fix_empty_read_write
branch
from
b4b074d to
ffb1b53
Compare
andreeaflorescu
changed the title
lauralt
reviewed
Feb 21, 2022
andreeaflorescu
force-pushed
the
fix_empty_read_write
branch
2 times, most recently
from
5e332bc to
f96635e
Compare
To keep consistent with the standard library, return ok(0) instead of out bound error when the slice passed as a parameter for read/write is empty. Signed-off-by: Andreea Florescu <[email protected]> Co-author: [email protected]
andreeaflorescu
force-pushed
the
fix_empty_read_write
branch
from
f96635e to
5d0cbc1
Compare
jiangliu
approved these changes
Feb 28, 2022
lauralt
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
This keeps the vm-memory interface consistent with the standard I/O, returning Ok(0) when the reader/writer is empty.
This PR adds a test on top of #186 and fixes the other issues reported by the CI so we can merge it.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and followthe 50/72 git commit rule.
test.
unsafecode is properly documented.