-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement Request: Add "systemctl restart nginx" button #14
Comments
Wouldn't nginx reload make more sense? This would make sure you don't end up with a nginx that won't start because of syntax errors. |
Well, ideally youd build the output of ‚nginx -t‘ into the you as well. Or add a button ‚check‘ and restart/reload afterwards. True, good point. |
|
But for any of this to work the nginx binary will need to be mounted into the container. |
Hello @LucaNerlich, thank you very much for your issue. You're right, of course. The feature is important and will come. The goal for the next release is to manage multiple nginx instances. Since there are environments where nginx is running on both bare-metal and docker, I am looking for a good solution to cover both. I imagine that when integrating an nginx instance into nginx ui the type of the instance is specified (baremetal/docker). |
To execute a command on non-dockerized nginx from inside a docker container is going to be tricky / hacky. Im unsure myself, on how a good solution would look like. |
My approach would be an SSH connection to the server with the necessary permissions to trigger a reload from nginx. The access data would then have to be stored in the form of a user management system. This would also allow the infrastructure to ensure that everyone is only allowed to do what the admin allows. :) Best David |
I've been pitching this tool at my workplace and this is the main feature stopping us from using it right now. |
@LucaNerlich @rzabarazesh @TheFehr @kennyparsons I added a working button that restarts. Do any of you want to collaborate on my fork? |
It would be great, if someone could add a button which executes systemctl restart nginx on the underlying machine.
Then everything nginx related could be handled via this ui.
As of right now, I need to edit something AND login via ssh and restart nginx for the changed to come into effect.
Thanks for the great work so far :)
The text was updated successfully, but these errors were encountered: