Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 2.7 and 3.5 support, add Python 3.9 support #168

Merged
merged 8 commits into from
Mar 24, 2021

Conversation

Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Mar 20, 2021

@codecov
Copy link

codecov bot commented Mar 20, 2021

Codecov Report

Merging #168 (0b05957) into master (7843f6f) will decrease coverage by 1.04%.
The diff coverage is 94.54%.

❗ Current head 0b05957 differs from pull request most recent head 0579cad. Consider uploading reports for the commit 0579cad to get more accurate results

@@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
- Coverage   95.45%   94.40%   -1.05%     
==========================================
  Files           7        7              
  Lines         484      465      -19     
  Branches       99       92       -7     
==========================================
- Hits          462      439      -23     
- Misses         15       16       +1     
- Partials        7       10       +3     
Impacted Files Coverage Δ
w3lib/encoding.py 98.52% <0.00%> (-1.48%) ⬇️
w3lib/util.py 60.00% <60.00%> (-9.70%) ⬇️
w3lib/form.py 96.00% <100.00%> (-0.43%) ⬇️
w3lib/html.py 93.69% <100.00%> (-0.17%) ⬇️
w3lib/url.py 97.96% <100.00%> (-0.09%) ⬇️
w3lib/http.py 96.87% <0.00%> (-3.13%) ⬇️

Copy link
Member

@elacuesta elacuesta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 💪

Copy link
Member

@noviluni noviluni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the tests/py3-ignores.txt file used?

It was created in 2014. I see there was a similar file in Scrapy (scrapy/scrapy@350aa67), but it was used in the conftest. Where is this file used in this project? Could we remove it on this PR or do you prefer to open a new PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants