Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Out of date pandas function calls (iteritems vs items). #372

Closed
iraxter opened this issue Jun 9, 2023 · 1 comment · Fixed by #373
Closed

Out of date pandas function calls (iteritems vs items). #372

iraxter opened this issue Jun 9, 2023 · 1 comment · Fixed by #373
Labels
dependencies Pull requests that update a dependency file

Comments

@iraxter
Copy link

iraxter commented Jun 9, 2023

Describe the bug

A number of the internal sksurv functions use iteritems() on dataframes which is no longer supported by pandas 2+. Looks like pyproject.toml notes this and attempts to suppress warnings but I was still receiving warnings when using pandas 1.5.3 (code would not run on pandas 2+ versions)

Grepping the codebase looks like column.py, arffwrite.py, util.py, conftest.py, test_io.py, and test_preprocessing.py all use iteritems(), could those be changed to items() instead?

@sebp
Copy link
Owner

sebp commented Jun 10, 2023

Currently, pandas 2 is not supported. Changing iteritems() to items() and requiring pandas >= 1.0 is certainly possible.

@sebp sebp added the dependencies Pull requests that update a dependency file label Jun 10, 2023
sebp added a commit that referenced this issue Jun 10, 2023
@sebp sebp mentioned this issue Jun 10, 2023
5 tasks
sebp added a commit that referenced this issue Jun 10, 2023
sebp added a commit that referenced this issue Jun 10, 2023
@sebp sebp closed this as completed in #373 Jun 10, 2023
sebp added a commit that referenced this issue Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants