Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add Code Review to Contributing.md #402

Merged
merged 2 commits into from
Feb 4, 2020
Merged

docs: Add Code Review to Contributing.md #402

merged 2 commits into from
Feb 4, 2020

Conversation

derekneuland
Copy link
Contributor

@derekneuland derekneuland commented Oct 31, 2017 •
edited
Loading

Fixes #399

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 31, 2017
@SendGridDX
Copy link
Collaborator

SendGridDX commented Oct 31, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@thinkingserious thinkingserious mentioned this pull request Jan 9, 2018
Closed
@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty type: docs update documentation change not affecting the code and removed hacktoberfest labels Sep 28, 2018
@childish-sambino childish-sambino changed the title Add Code Review to Contributing.md #399 docs: Add Code Review to Contributing.md #399 Feb 4, 2020
@childish-sambino childish-sambino changed the title docs: Add Code Review to Contributing.md #399 docs: Add Code Review to Contributing.md Feb 4, 2020
@childish-sambino childish-sambino merged commit 40d073e into sendgrid:master Feb 4, 2020
@thinkingserious
Copy link
Contributor

Hello @derekneuland,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@childish-sambino childish-sambino mentioned this pull request Nov 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio type: docs update documentation change not affecting the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Code Review to Contributing.md
5 participants
@derekneuland @SendGridDX @thinkingserious @childish-sambino @apigirl