[Solana][readability] PluginType type safety #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
agusaldasoro
approved these changes
Feb 20, 2025
| @@ -95,7 +99,7 @@ pub trait Admin { | |||
| fn set_ocr_config( | |||
| &self, | |||
| ctx: Context<SetOcrConfig>, | |||
| plugin_type: u8, // OcrPluginType, u8 used because anchor tests did not work with an enum | |||
| plugin_type: OcrPluginType, | |||
There was a problem hiding this comment.
Is this a breaking change? If yes, then we need to inform tooling team to update their interactions as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor type safety/readability improvement. Since zero_copy serialization of enums isn't possible, we stored the plugin type as a u8 in many places, but it can be made a bit safer with an additional type wrapper.