Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Use named return values for getNodes #13462

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

cedric-cordenier
Copy link
Contributor

@cedric-cordenier cedric-cordenier commented Jun 7, 2024

This is required by chainreader when there are multiple return values.

As per Bolek's feedback on my PR here: #13427, I'm splitting this out to get it in sooner.

Copy link
Contributor

github-actions bot commented Jun 7, 2024

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

Copy link
Contributor

github-actions bot commented Jun 7, 2024

I see you updated files related to contracts. Please run pnpm changeset in the contracts directory to add a changeset.

@cedric-cordenier cedric-cordenier marked this pull request as ready for review June 7, 2024 12:30
@cedric-cordenier cedric-cordenier added this pull request to the merge queue Jun 7, 2024
Merged via the queue into develop with commit 8c75b1a Jun 7, 2024
105 of 106 checks passed
@cedric-cordenier cedric-cordenier deleted the chore-chainreader-changes branch June 7, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants