add wait_deadline function
#226
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass around deadlines and only calculate timeouts just before the relevant syscall. Prevents some needless calls to `Instant::now()` and makes `wait_deadline` simpler to implement.
|
(CI did not, in fact, go well) Should be all fixed now, that failure seems to be an issue with nightly afaict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A handy function if your code mostly relies on deadlines rather than timeouts.
Also changes the internal pollers to use deadlines and has them calculate timeouts just before the relevant syscall. This prevents a couple extra calls to
Instant::now(), hypothetically makes the timeout more accurate, and in my opinion is a little bit easier to reason about.(I only compiled and tested epoll so here's hoping CI goes well)