Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: subprojects filtering #278

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

37IulianPopovici
Copy link
Contributor

@37IulianPopovici 37IulianPopovici commented Jan 10, 2024

This comes in completion of this PR raise by the client, adding tests

  • Tests written and linted
  • Documentation written
  • Commit history is tidy

What this does
This resolves #195, allowing the tool to properly recognize --sub-project arguments that refer to nested subprojects, e.g. foo/bar for the Gradle project path :foo:bar.

@37IulianPopovici 37IulianPopovici requested a review from a team as a code owner January 10, 2024 11:31
@37IulianPopovici 37IulianPopovici force-pushed the fix/subprojects-filtering branch from 879cc2f to fb4c28e Compare January 10, 2024 11:35
@37IulianPopovici 37IulianPopovici force-pushed the fix/subprojects-filtering branch from fb4c28e to 0ac8d11 Compare January 16, 2024 12:08
fix: complete proj path on subprojects filtering
@37IulianPopovici 37IulianPopovici force-pushed the fix/subprojects-filtering branch from 0ac8d11 to 93dd1e4 Compare January 16, 2024 12:31
@37IulianPopovici 37IulianPopovici merged commit e216d5c into main Jan 17, 2024
6 checks passed
@37IulianPopovici 37IulianPopovici deleted the fix/subprojects-filtering branch January 17, 2024 07:39
@snyksec
Copy link

snyksec commented Jan 17, 2024

🎉 This PR is included in version 4.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please use complete sub project path instead of name to check for onlyProj
4 participants