Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use complete project path when filtering subprojects #268

Closed
wants to merge 1 commit into from

Conversation

damianw
Copy link
Contributor

@damianw damianw commented Nov 22, 2023

  • Tests written and linted
  • Documentation written
  • Commit history is tidy

What this does

This resolves #195, allowing the tool to properly recognize --sub-project arguments that refer to nested subprojects, e.g. foo/bar for the Gradle project path :foo:bar. Currently, this does not work.

Notes for the reviewer

I'm not sure how to write the test for this, since I haven't dug into the repo too much. Please let me know if you have a recommendation for anything else that needs to be done.

How should this be manually tested?

Ran with --sub-project for a nested Gradle subproject, e.g. foo/bar, and found it to be recognized.

@damianw damianw requested a review from a team as a code owner November 22, 2023 18:59
@CLAassistant
Copy link

CLAassistant commented Nov 22, 2023

CLA assistant check
All committers have signed the CLA.

@anthogez
Copy link
Contributor

Thanks @damianw for your collaboration, we will review your changes and loop back to you.

@37IulianPopovici
Copy link
Contributor

Hey @damianw! We would love to keep you as a contributor on this change, so, can you please make a new branch and open a new PR with the exact change from our main project? Your change is great, but I want to add some small updates (tests mainly), and I cannot add them here.

@damianw
Copy link
Contributor Author

damianw commented Jan 9, 2024

Thanks @37IulianPopovici! I don't have permission to create a branch on this repo, if that's what you're asking. I'm happy to do that if given permission, but I also don't mind if you commandeer this change and take ownership of it.

@37IulianPopovici
Copy link
Contributor

Hey @damianw, thanks a lot for your patience! Waiting for the cli PR to be approved and released

@damianw
Copy link
Contributor Author

damianw commented Jan 17, 2024

Thanks, appreciate you looking into it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please use complete sub project path instead of name to check for onlyProj
4 participants