Use complete project path when filtering subprojects #268
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
This resolves #195, allowing the tool to properly recognize
--sub-project
arguments that refer to nested subprojects, e.g.foo/bar
for the Gradle project path:foo:bar
. Currently, this does not work.Notes for the reviewer
I'm not sure how to write the test for this, since I haven't dug into the repo too much. Please let me know if you have a recommendation for anything else that needs to be done.
How should this be manually tested?
Ran with
--sub-project
for a nested Gradle subproject, e.g.foo/bar
, and found it to be recognized.