Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Avoid using the call to System.Diagnostics.Requires #79

Merged
merged 2 commits into from
Jun 1, 2018
Merged

Avoid using the call to System.Diagnostics.Requires #79

merged 2 commits into from
Jun 1, 2018

Conversation

martinmine
Copy link
Contributor

Newer versions of VS are having issues with CCRewrite and it turns out this is something that is going to die out in the future as Microsoft is reluctant on maintaining this. (see microsoft/CodeContracts#476)

This PR implements the System.Diagnostics.Requires functions in the Requires class. Since this is in the same namespace as the other classes, all the existing calls to System.Diagnostics.Requires are redirected to this implementation. As a result, the CCRewrite is no longer required to be installed on machines wanting to use this framework which simplifies development (and deployment) a lot. It also fixes the issue discussed on #42

@shakeelmohamed shakeelmohamed changed the base branch from master to develop June 1, 2018 19:04
@shakeelmohamed shakeelmohamed merged commit 0edaa1a into splunk:develop Jun 1, 2018
@shakeelmohamed
Copy link
Contributor

Thanks for your dedication in finding a fix for this @martinmine!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants