Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix connection not established error on windows #662

Closed
wants to merge 1 commit into from

Conversation

devotip
Copy link

@devotip devotip commented Oct 20, 2022

this is a fix for #660

@cla-bot
Copy link

cla-bot bot commented Oct 20, 2022

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient...

@devotip
Copy link
Author

devotip commented Oct 28, 2022

Is there something I can do to move forward?

@stephane
Copy link
Owner

@devotip Thank you for your patch.
The Windows RTU code has serious issues so I intend to rewrite it, in the meantime, I applied a very similar solution to your patch except the function returns a boolean value.

@stephane stephane closed this Nov 28, 2022
epsilonrt pushed a commit to epsilonrt/libmodbus that referenced this pull request Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants