Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More intuitive ways to maximise or minimise widget windows #2761

Closed
ksraj123 opened this issue Jan 17, 2021 · 6 comments
Closed

More intuitive ways to maximise or minimise widget windows #2761

ksraj123 opened this issue Jan 17, 2021 · 6 comments

Comments

@ksraj123
Copy link
Member

Currently dragging a maximised widget window from the top restores it. It would be intuitive if dragging it back to the top maximises it. This type of functionality is provided in the user interface of many modern operating systems and work environments as well.

Here is what it would look like after the proposed changes -

drag to top to maximise

I have implemented a demo version of this, would open a PR if this is something we want.

Also, currently clicking once of a maximised window restores it. Maybe double clicking on a window should maximise it. This is also a standard way to maximise things in modern applications.

Thanks, Please share feedback and suggestions.

@meganindya
Copy link
Member

We have discussed this before. But since we're moving on to MB 2, feature additions on this application is not a priority. The objectives on this repository roughly are: fix bugs (like #2758), code cleanup and documentation of important units (might be helpful while porting to MB2), and retiring work (simple improvements like #2707).

@meganindya
Copy link
Member

You can always create a PR for issues like this one. But if the implementation is a lot of work, it might probably not be worth doing it. BTW, your PR (#2747) on widgetWindow was a healthy contribution.

@meganindya
Copy link
Member

There's actually a bigger problem here with widgets. The DOM configuration is part of the codebase instead of HTML/CSS and so, barely any widget actually benefits from the full screen mode. The JSEditor takes advantage of the full screen mode, but the rest do not. I doubt if full screen is at all required. The UI actually looks bad when the widget window is in full screen mode but the elements don't scale up.

I don't think redesigning the UI elements of all widgets are worth the effort. One way out could be to disable the full screen button for those widgets. Your suggestion to enable mouse drag to top is fine, but then there's this catch.

@ksraj123
Copy link
Member Author

@meganindya For the widgets where we could better utilise the full screen mode with simple changes, we could make them. For others, if the fullscreen mode helps somehow then we could leave it as it is else disable it. The PR for this issue could also implement a way to easily disable fullscreen mode of a widget (there would be no maximise icon and other ways to maximise would also not work). Enhancements to fullscreen mode of meterWidget done in #2771 . Thanks

@meganindya
Copy link
Member

Ok, I think mouse drag maximize-minimize is fine. If you can create a PR please do that first.

@meganindya
Copy link
Member

For the rest, we could discuss all the possibilities separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants