Refactor, Documentation and Bug Fix: widgets/widgetWindow #2747
Conversation
…tup outside constructor
|
@meganindya Please have a look at this. Thanks |
There was a problem hiding this comment.
Mostly looks fine, but there are some minor gliches. Probably not created by you; some were probably hidden due to previous errors.
I saw that there is something off with the full screen. Please investigate if you can. You could try out using all the widgets for testing sake.
| */ | ||
| sendToCenter() { | ||
| const canvas = docById("myCanvas"); | ||
| const fRect = this._frame.getBoundingClientRect(); |
There was a problem hiding this comment.
Uncaught TypeError: Cannot read property 'getBoundingClientRect' of undefined
at sendToCenter (widgetWindows.js:359)There was a problem hiding this comment.
The reason for this error was how the sendToCenter function was being used in the code elsewhere. Which led to wrong value of this in it. Binding the context in the constructor solved this issue.
js/widgets/widgetWindows.js
Outdated
| console.log("From WidgetWindow addButton"); | ||
| console.log(`type of icon = ${typeof(icon)}`); | ||
| console.log(`type of iconSize = ${typeof(iconSize)}`); | ||
| console.log(`type of label = ${typeof(label)}`); |
|
@meganindya Found an issue with the pitch slider widget in fullscreen mode. The slider was overflowing over other elements in fullscreen mode, it has been fixed.
Please point out more issues or possible enhancements in the fullscreen mode? Thanks |
Scrolling in any widget window leads to errors in the console.
The issue originated from
widgets/widgetWindow, closer inspection revealed that this file's porting to ES6 done in #2722 had several other issues.This PR aims to fix bugs, properly port to ES6 and add jsDoc style documentation for
widgetWindow.As always, please share feedback and suggestions. Thanks