Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edge offset #17

Merged
merged 6 commits into from
Jan 29, 2019
Merged

Edge offset #17

merged 6 commits into from
Jan 29, 2019

Conversation

jeffmhubbard
Copy link
Contributor

This adds the --offset option. Works as expected with --halign and --valign except when set to center, the corresponding offset is ignored.

svenstaro
svenstaro requested changes Jan 28, 2019
View reviewed changes
Copy link
Owner

@svenstaro svenstaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR! I'd like to see a few minor changes but all in all this is solid.

@svenstaro
Copy link
Owner

Thanks a lot! Merging once travis is happy!

@svenstaro svenstaro merged commit 6ef7956 into svenstaro:master Jan 29, 2019
@svenstaro svenstaro mentioned this pull request Jan 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svenstaro svenstaro svenstaro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffmhubbard @svenstaro