Prevent assertion error when using the withLoggedIn test helper.

[mikesname]

Access the cookie params via the protected members of CookieTokenAccessor, rather than via the (deprecated) members of AuthConfig, which now throw an error.

I trust it's not this change which is causing the cache-related test failures!

[gakuzzzz]

Good catch! thanks!

However, if the config parameter does not use CookieTokenAccessor, the tests what use this config will be failed.

It need to use config.tokenAccessor

[mikesname]

Aye, right you are 😄

I looked at using the tokenAccessor but none of the relevant params are exposed in the trait... do you have a nicer way in mind?

[gakuzzzz]

mmm, It's a bit difficult...
TokenAccessor should teach the way how a request has token to FakeRequest.
However play2-auth core should not depends on play2-auth-test and play2-test modules...

[mikesname]

I changed the PR so instead of extending the CookieTokenAccessor, the helper just blows up if your AuthConfig isn't using one. Not a nice solution, but I can't think of anything better without much larger changes.

[gakuzzzz]

Thanks for proposal!

I had consider this problem, we provides a way what any TokenAccessor can test.
So I intoroduce a way that skip tokenaccessor.extract

play2-auth/module/src/main/scala/jp/t2v/lab/play2/auth/AsyncAuth.scala

Lines 38 to 44 in 3016950

	private[auth] def extractToken(request: RequestHeader): Option[AuthenticityToken] = {
	if (play.api.Play.isTest(play.api.Play.current)) {
	request.headers.get("PLAY2_AUTH_TEST_TOKEN") orElse tokenAccessor.extract(request)
	} else {
	tokenAccessor.extract(request)
	}
	}

play2-auth/test/src/main/scala/jp/t2v/lab/play2/auth/test/Helpers.scala

Line 17 in 3016950

fakeRequest.withHeaders("PLAY2_AUTH_TEST_TOKEN" -> token)

[mikesname]

👍 Nice one, that's a much better solution!