Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove executable products and rename executable targets to kebab-case (fixes #21) #22

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

stackotter
Copy link

This is my solution to #21 as described in the issue.

@stackotter
Copy link
Author

Ok hopefully that should be working now, I've updated all of the scripts to operate on targets instead of products now.

Btw these integration-tests are sick! I was prepared for mundane test case output, but no! I need to get onto this for my image formats library 😅.

@tayloraswift
Copy link
Owner

haha thanks! unfortunately it looks like utils-test is broken

@stackotter
Copy link
Author

Doesn't look like the macOS issue is due to anything that I've changed (I've had similar things in my workflows in the past), but that Linux issue is definitely due to my changes. Seems like SwiftPM doesn't build executable targets all the way to an executable on linux (it stops once it produces a .o file).

On Linux swift build -c debug --product unit-test does what swift build -c debug --target unit-test does on macOS, even without any explicit unit-test product (probably due to a generated product). So swift build -c debug --target unit-test is the way to go on macOS and swift build -c debug --product unit-test is the way to go on Linux...

I think the best solution would be to update the shell scripts to use swift run instead of splitting each set of tests into a building phase and a running phase. swift run unit-test works as you'd expect on both macOS and Linux (I haven't tested it on Windows). Would you be ok with that as a solution?

@tayloraswift
Copy link
Owner

sounds good to me!

@stackotter
Copy link
Author

Hopefully that should work now 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants